We added support for vector storage and search in Oracle Coherence CE 24.09, and would like to contribute Spring AI vector store implementation (and Spring Boot Starter) for it.
Comment From: aseovic
@markpollack Just a friendly nudge to review this PR... ;-)
Comment From: markpollack
@aseovic having some build issues with removing boot deps and installing checkstyle... will merge once done.
A couple things wrt to testing. Having the automated tests is important as there will always be drift. I'm not married to test containers, but getting something in place would be useful.
Also, we do have https://github.com/spring-projects/spring-ai-integration-tests where most tests are failing due to lack of API keys, but are in the process of sorting that out. There is also a contribution for OCI Embedding model, but I can't get oracle cloud to cooperate with me. See this comment. Is there something you can do to help me out there?
Comment From: aseovic
A couple things wrt to testing. Having the automated tests is important as there will always be drift. I'm not married to test containers, but getting something in place would be useful.
Of course, and we do have tests in the PR. They are just not using TC, but our own distributed testing framework instead.
There is also a contribution for OCI Embedding model, but I can't get oracle cloud to cooperate with me. See this comment. Is there something you can do to help me out there?
I'm not sure. I only have access to resources in Phoenix and Ashburn regions, and that's through my team/org, so not publicly shareable. I'm a bit confused though -- it says you merged it on Sep 26?
Comment From: aseovic
@markpollack Any chance we can get this merged soon? Keeping it in sync with the changes in main is pita...
Comment From: markpollack
on it
Comment From: markpollack
Thanks to the man who brought you the Spring Expression Language!
Merged in f6a648e85c2038a33c6305681e1d848aa226811f
can you add docs in another PR @aseovic ?
Comment From: aseovic
Sure, will do. Thanks!