and minor fixes ( typo, unused code ).
Function callbacks from chatOptions and constructor parameters were not properly merged because the toolFunctionCallbacks field in AzureOpenAiChatModel was hardcoded to an empty list (List.of()).
Ensuring both sources of function callbacks are combined into the functionCallbackRegister during initialization.
AS-IS
Only one callback function was registered from chatOptions.
TO-BE Both callback functions were merged.
Comment From: tzolov
This is nasty indeed:
Function callbacks from chatOptions and constructor parameters were not properly merged because the toolFunctionCallbacks field in AzureOpenAiChatModel was hardcoded to an empty list (List.of()).
Thanks for catching and fixing it. Much appreciated!
P.S. In the future please submit the unrelated changes in a separate PR
Comment From: tzolov
Rebased and merged at d8583271c7f28dea885c11c0b96f8a1e0ba983f8
Comment From: jitokim
P.S. In the future please submit the unrelated changes in a separate PR
Got it, I'll do that. And thanks for the review. :)