Minor overall affect but could impact some pull requests. I've had this sitting around since January 20th and it's had little to no impact during rebasing since so it's low risk.
Comment From: hazendaz
rebased only.
Comment From: hazendaz
Looked over recent PRs to see if any consideration of impact and also rebased off a number of more recent without issue. Merging this in. I'll likely run some subsequent formatting checks. Ultimately will turn on auto formatting but try to limit incoming formatting changes in more isolated sets like this.
Comment From: harawata
Oh, I thought it would be two spaces for a tab like the Java sources. XD
Comment From: hazendaz
I think it was 2 based or to mostly match the general overall. Quick look appears less than before with tabs and aligned.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Iwao AVE! notifications@github.com Sent: Friday, February 28, 2020 2:49:26 AM To: mybatis/mybatis-3 mybatis-3@noreply.github.com Cc: Jeremy Landis jeremylandis@hotmail.com; State change state_change@noreply.github.com Subject: Re: [mybatis/mybatis-3] [ci] Xml tabs to spaces (site/tests) (#1796)
Oh, I thought it would be two spaces for a tab like the Java sources. XD
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mybatis/mybatis-3/pull/1796?email_source=notifications&email_token=AAHODI76SDJ3VYP7XB5XSYLRFC6YNA5CNFSM4KBZPK6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENHTEIY#issuecomment-592392739, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI2R4PKU5OM3IUUMLLLRFC6YNANCNFSM4KBZPK6A.
Comment From: hazendaz
Ah I see what you mean. It was less space but many 4 spaces. I'd call that habit. Majority of software i work on uses 4.
Long term goal is to get to auto format here which can address being 2 spaced everywhere.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Jeremy Landis jeremylandis@hotmail.com Sent: Friday, February 28, 2020 7:15:14 AM To: mybatis/mybatis-3 mybatis-3@noreply.github.com; mybatis/mybatis-3 reply@reply.github.com Cc: State change state_change@noreply.github.com Subject: Re: [mybatis/mybatis-3] [ci] Xml tabs to spaces (site/tests) (#1796)
I think it was 2 based or to mostly match the general overall. Quick look appears less than before with tabs and aligned.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Iwao AVE! notifications@github.com Sent: Friday, February 28, 2020 2:49:26 AM To: mybatis/mybatis-3 mybatis-3@noreply.github.com Cc: Jeremy Landis jeremylandis@hotmail.com; State change state_change@noreply.github.com Subject: Re: [mybatis/mybatis-3] [ci] Xml tabs to spaces (site/tests) (#1796)
Oh, I thought it would be two spaces for a tab like the Java sources. XD
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mybatis/mybatis-3/pull/1796?email_source=notifications&email_token=AAHODI76SDJ3VYP7XB5XSYLRFC6YNA5CNFSM4KBZPK6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENHTEIY#issuecomment-592392739, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHODI2R4PKU5OM3IUUMLLLRFC6YNANCNFSM4KBZPK6A.
Comment From: harawata
Thank you for the comment, @hazendaz , I prefer 2 spaces, but it's just a matter of preference, so let's not worry about it until auto-format arrives. :D