Comment From: philwebb
Caused by #22594
Comment From: philwebb
I'm not sure how to fix this one :(
Comment From: wilkinsona
Gah!
Comment From: sdeleuze
Package tangles are bad, and we should avoid them, but here I think this refactoring just made this previously hidden issue visible to static code analysis.
Reverting those changes would just hide it again, not solve it, with a regression on native image support.
Since I guess we have to live with this package tangle in Boot 2.x timeframe, could we keep the code as it is and solve this properly in Boot 3?
Comment From: philwebb
I agree that this was a previously hidden issue, but I hope that we don't need to live with it until 3.x. I tried adding a new LoggingSystemFactory
interface with an implementation the uses spring.factories
by default.
@sdeleuze Will you be able to replace LoggingSystem.SYSTEM_FACTORY
in the native image to do what you need? I think we did something similar with EnvironmentPostProcessorsFactory
.
Comment From: sdeleuze
Thanks I will check this tomorrow.
Comment From: sdeleuze
It should be possible to adapt, the main point to clarify is if it will require build time transformations (not supported currently with reflection
mode) or not. We will discuss that in our tomorrow meeting and check that in practice after spring-graalvm-native
0.8.1
release. cc @aclement