Sending HELLO 3 to Redis sentinel results in an invalid response. The Sentinel HELLO response contains a lingering standalone element.
Version: unstable (0cabe0cfa7290d9b14596ec38e0d0a22df65d1df)
Sentinel (note: Element count does not match, lingering standalone):
%7
$6
server
$5
redis
$7
version
$11
999.999.999
$5
proto
:3
$2
id
:12
$4
mode
$8
sentinel
$10
standalone
$7
modules
*0
Standalone server (correct):
%7
$6
server
$5
redis
$7
version
$11
999.999.999
$5
proto
:3
$2
id
:7
$4
mode
$10
standalone
$4
role
$6
master
$7
modules
*0
Diff:
Comment From: mp911de
Retest with 0f026af1, issue still persists.
Using redis-cli hangs:
./redis-cli -p 26379
127.0.0.1:26379> HELLO 3
(nothing happens after here)
Comment From: mp911de
This issue still persists in 53ac8c7d which renders Sentinel using RESP 3 unusable.
Comment From: antirez
Thanks @mp911de, I'll fix that.
Comment From: antirez
@mp911de fixed, thank you.
Comment From: mp911de
Thanks. The response structure is fixed now but the map count (7) does not match the number of response elements.
Reply as of 7f794a1:
%7
$6
server
$5
redis
$7
version
$11
999.999.999
$5
proto
:3
$2
id
:5
$4
mode
$8
sentinel
$7
modules
*0
So either the map count should be 6 or a missing map key-value pair should be supplied.
Comment From: antirez
Fixed in c9388ecc7, thank you so much @mp911de