Redis redis-cli --cluster create no longer honors --cluster-yes

I had a look through the code, in 5.0.8 confirmWithYes in redis-cli.c used to check the flags

if (config.cluster_manager_command.flags & CLUSTER_MANAGER_CMD_FLAG_YES) {
        return 1;
    }

in 6.0.3 it no longer does.

This was useful functionality for creating a cluster non-interactively.

Let us know if this change was intentional or no, thanks.

Comment From: itamarhaber

Hello @deckpuncher

Looks like this was introduced by https://github.com/antirez/redis/commit/f4d2abd3df760e370510c79d2d5e27c22aa1d1ce /cc @bsergean

Comment From: antirez

Hi, this is likely a regression. I'll publish 6.0.4 soon and we can fix it.

Comment From: bsergean

Oops sorry I'll take a look asap.

On May 22, 2020, at 8:12 AM, Salvatore Sanfilippo notifications@github.com wrote:

Hi, this is likely a regression. I'll publish 6.0.4 soon and we can fix it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antirez/redis/issues/7308#issuecomment-632744969, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UO3XNK2MLOO2VLBRM3RS2I4NANCNFSM4NHQYPLA.

Comment From: bsergean

Actually I think my commit fixed this problem.

Another one to put in the 6.0. patch branch in my opinion is this redis-cli ACL fix for cluster -> 54cb8214d9bca268458752b3be92f038d4f52445

Which is in the unstable branch now.

On May 22, 2020, at 8:12 AM, Salvatore Sanfilippo notifications@github.com wrote:

Hi, this is likely a regression. I'll publish 6.0.4 soon and we can fix it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antirez/redis/issues/7308#issuecomment-632744969, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UO3XNK2MLOO2VLBRM3RS2I4NANCNFSM4NHQYPLA.

Comment From: oranagra

already handled. thanks.