when: srand_seed is 1558930444202 srand_seed is 1559120199796
Comment From: AngusP
To reproduce you'll need to edit /tests/geo.tcl:L233 to be set srand_seed 1558930444202 and/or set srand_seed 1559120199796, or add these to the set regression_vectors on L51
{1559120199796 3594 169.2052526721755 -65.068242845622933}
{1558930444202 4240 -105.35319336007964 65.675243332830831}
./runtest --single unit/geo --only "GEOADD + GEORANGE randomized test"
Gives a fail similar to this:
...
place:14069 -> {5.27970582246780396 68.43798711790761047} 4163.0046103452187 (only in Tcl)
place:14437 -> {0.56737571954727173 68.41073126128122794} 4039.7058916392307 (only in Tcl)
place:15142 -> {4.05866771936416626 67.69250027773442469} 4194.8825608511788 (only in Tcl)
place:19077 -> {8.68558555841445923 69.47469821096187559} 4158.4765395844579 (only in Tcl)
place:19085 -> {7.14333683252334595 69.25353365092490776} 4139.9457646297224 (only in Tcl)
place:2661 -> {7.8073766827583313 69.45269683129880889} 4139.0475411030175 (only in Tcl)
place:3154 -> {1.91702574491500854 69.78184558216592848} 3962.7596628203169 (only in Tcl)
place:3240 -> {1.89562171697616577 69.88721647548081251} 3953.5679316952087 (only in Tcl)
place:3869 -> {3.45919936895370483 69.52419371104028301} 4023.9208418674802 (only in Tcl)
place:3871 -> {4.80832904577255249 67.50962268080928652} 4230.7156862654092 (only in Tcl)
place:4212 -> {4.7871825098991394 69.30126245035526722} 4076.651052214444 (only in Tcl)
place:5677 -> {0.0316581130027771 66.90548963552895145} 4150.2067108324127 (only in Tcl)
place:8077 -> {5.53663462400436401 67.76411121992806841} 4227.9481923016347 (only in Tcl)
place:869 -> {1.14537566900253296 66.23736501985996483} 4238.7256045278555 (only in Tcl)
place:9109 -> {2.90229767560958862 69.59145507172451062} 4003.9764792922883 (only in Tcl)
place:9440 -> {1.25248700380325317 66.32190303996623015} 4234.5683316083387 (only in Tcl)
[err]: GEOADD + GEORANGE randomized test in tests/unit/geo.tcl
Expected 'OK' to equal or match 'FAIL'
[1/1 done]: unit/geo (3 seconds)
The End
Execution time of different units:
3 seconds - unit/geo
!!! WARNING The following tests failed:
*** [err]: GEOADD + GEORANGE randomized test in tests/unit/geo.tcl
Expected 'OK' to equal or match 'FAIL'
Cleanup: may take some time... OK
Comment From: antirez
Yep happens for extreme coordinates... Probably acceptable in the implementation. There were many many bugs like that in the past that I solved but still is not perfect. There is to understand if to fix the test or Redis.
Comment From: madolson
@antirez https://github.com/antirez/redis/pull/5779 Fixes some of them. It fixes these at least.
Comment From: madolson
This is fixed AFAIK