Redis [QUESTION] more efficiency way for geohash

Hi,

In geohash_helper.c, I find the following two lines:

    bounds[0] = longitude - rad_deg(radius_meters/EARTH_RADIUS_IN_METERS/cos(deg_rad(latitude)));
    bounds[2] = longitude + rad_deg(radius_meters/EARTH_RADIUS_IN_METERS/cos(deg_rad(latitude)));

why not save rad_deg(radius_meters/EARTH_RADIUS_IN_METERS/cos(deg_rad(latitude))) result for later use? it will be more efficiency.

Comment From: oranagra

since rad_deg and deg_rad are inline functions (or alternatively can be marked as "pure"), the compiler knows very well that this code can be optimized and changing won't affect the efficiency.

it may improve readability, but actually i think that in this case it won't make a difference too.