Redis [BUG] SET with GET option: WRONGTYPE Error

Describe the bug

Setting with the GET option returns an error, but still sets the value. Is this intentional?

getGenericCommand can return an error if the value is not a string. However, setGenericCommand does not check this return value. It seems to me that the operation should be aborted at that point.

To reproduce

127.0.0.1:6378> hset x 1 2
(integer) 1
127.0.0.1:6378> set x 2 get
(error) WRONGTYPE Operation against a key holding the wrong kind of value
127.0.0.1:6378> get x
"2"

Expected behavior

The operation is aborted and the key is not set.

Comment From: madolson

No, probably not, lemme take a look.

Comment From: madolson

Yeah, we're missing the error check there, we should be able to fix this quickly.

Comment From: braddunbar

Thank you @madolson!