Added support for autoconfiguration of Oracle Universal Connection Pool. Fixes gh-12865.
Comment From: snicoll
I've started to review and polish this. Unfortunately the use of alises has some limit. UCP requires us to map the driver class name to connection-factory-class-name
. DBCP2's BasicDataSource
happens to have exactly the same property for something entirely different.
I've created #23480
Comment From: fabio-grassi-gbs
Yes, I saw the conflict with BasicDataSource. It’s easy to make it work (it doesn’t right now), but I haven’t yet found a way to make it right. Ciao, FG
Comment From: snicoll
@fabio-grassi-gbs thank you for making your first contribution to Spring Boot.
Comment From: fabio-grassi-gbs
It was a pleasure. I like the improvements you made to my code.
Comment From: davidkarlsen
@fabio-grassi-gbs How can one control more advanced configuration settings like onsConfiguration
, fastConnectionFailoverEnabled
, `validateConnectionOnBorrow´ etc?
Comment From: davidkarlsen
@fabio-grassi-gbs ping?
Comment From: fabio-grassi-gbs
You can set any property via application.properties. For instance:
spring.datasource.oracleucp.validateConnectionOnBorrow=false spring.datasource.oracleucp.connection-properties.autoCommit=false spring.datasource.oracleucp.fastConnectionFailoverEnabled=true
Comment From: snicoll
Thanks @fabio-grassi-gbs.
@davidkarlsen please review the guidelines for contributing and ask questions on StackOverflow or Gitter.