Hello, @antirez : Sometimes we forget to run benchmark with -a or with wrong requirepass, but benchmark still run performance testing without any error. When we run benchmark but forget to set the right requirepass, benchmark should return error.

5847

Comment From: filipecosta90

@redis/core-team I believe this is still a valid issue. We should not continue the tests on ERR replies of any kind ( at the consequence of inducing users in error ). Even tough we do output the AUTH error message I believe we can do better and should exit the benchmark process with error right away. WDYT? Current error:

$ redis-benchmark 
ERROR: NOAUTH Authentication required.
ERROR: failed to fetch CONFIG from 127.0.0.1:6379
WARN: could not fetch server CONFIG
(...)

Comment From: oranagra

@filipecosta90 i agree, unless there are cases were we wanna benchmark the performance of the error response (which i doubt there are), we should terminate the benchmark and reflect the problem with both a print to stderr and the process exit code.

IIUC the referenced PR was closed because the print was added? (also that PR was too specific, referring to just one type of error)

Comment From: oranagra

re-opening till we fix possible regression preventing the fixed version use on RE. see https://github.com/redis/redis/pull/8855#issuecomment-826361456