Redis Allow windcard in include - Nineya|java/go/python

Would be great to allow wildcards in include config directive, like include /etc/redis/conf.d/*.conf

Comment From: sambo770

Hello, Dear developer(s):

FYI, I have a bug open against the redis package in Debian to supply a default config file with "include /etc/red/conf.d/*.conf", to facilitate easier upgrades/downgrades of redis on dev and production systems. The aforementioned bug there is contingent on the fix of this bug.

Here's a URL to the packaging bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988947

I shall cross-reference in Debian as well.

Please consider adding to the priority of this bug as it's increasingly difficult to maintain multiple systems at varying versions of redis the moment we make any changes/customizations to the default configuration file.

Thank you, in advance for your attention (but primarily for an awesome in-memory database!) Sincerely, S.

Comment From: yossigo

I think it's a good idea, duplicate of #8909. We will also need to consider how this should work with CONFIG REWRITE, this is already an issue - see #8735.

Comment From: sambo770

Okay, great. Thanks for the reply. I submitted pull request #8980 in the hope that this can be of some help in getting this issue resolved quicker. I've tested locally and it seems to do the job nicely.

Thanks again!

Comment From: sambo770

We will also need to consider how this should work with CONFIG REWRITE, this is already an issue - see #8735.

Incidentally, while I'm not an expert in the field and consequently not fully aware of all the issues surrounding CONFIG REWRITE, I'd like to point out that adding the globbing (as I did in the push request) and accepting wildcards is functionally equivalent to adding multiple include statements in close succession. Hence, the globbing doesn't really add any additional complexity, in principle, to whatever complexity already exists in relation to includes and CONFIG REWRITE.

In other words, my understanding is that adding wildcards is not going to regress or progress anything with regards to the aforementioned command as it's simply a short-hand to existing supported functionality.