Describe the bug
Define htab at line 107. https://github.com/redis/redis/blob/unstable/src/lzf_c.c#L107
Initialize at line 135,But it doesn't execute, because this macro "INIT_HTAB" always going to be 0. https://github.com/redis/redis/blob/unstable/src/lzf_c.c#L134
Why use it without initialization at line 146. https://github.com/redis/redis/blob/unstable/src/lzf_c.c#L146
Look forward to your kind advice.
Comment From: oranagra
please look at the documentation of lzf.
/*
* You may choose to pre-set the hash table (might be faster on some
* modern cpus and large (>>64k) blocks, and also makes compression
* deterministic/repeatable when the configuration otherwise is the same).
*/
#ifndef INIT_HTAB
# define INIT_HTAB 0
#endif
from my understanding, the initialization of this array is optional. it affects performance, and can cause the compression to be deterministic. we don't care for deterministic compression, so we can leave it uninitialized.