build code redis-6.2.5
CC lolwut5.o CC lolwut6.o CC acl.o CC gopher.o CC tracking.o CC connection.o In file included from acl.c:33: acl.c: In function ‘ACLStringHasSpaces’: acl.c:207:22: warning: array subscript has type ‘char’ [-Wchar-subscripts] 207 | if (isspace(s[i]) || s[i] == 0) return 1; | ~^~~ CC tls.o CC sha256.o CC timeout.o CC setcpuaffinity.o CC monotonic.o CC mt19937-64.o CC redis-cli.o CC cli_common.o CC redis-benchmark.o In file included from redis-cli.c:40: redis-cli.c: In function ‘completionCallback’: redis-cli.c:693:27: warning: array subscript has type ‘char’ [-Wchar-subscripts] 693 | while (isspace(buf[startpos])) startpos++; | ~~~^~~~~~~~~~ redis-cli.c: In function ‘hintsCallback’: redis-cli.c:718:41: warning: array subscript has type ‘char’ [-Wchar-subscripts] 718 | int endspace = buflen && isspace(buf[buflen-1]); | ~~~^~~~~~~~~~ redis-cli.c: In function ‘sdsCatColorizedLdbReply’: redis-cli.c:1082:29: warning: array subscript has type ‘char’ [-Wchar-subscripts] 1082 | if (len > 4 && isdigit(s[3])) { | ~^~~ LINK redis-server LINK redis-benchmark INSTALL redis-sentinel INSTALL redis-check-rdb INSTALL redis-check-aof LINK redis-cli
Hint: It's a good idea to run 'make test' ;)
make[1]: Leaving directory '/home/dsg/redis-6.2.5/src'
Comment From: oranagra
@icetech233 please specify which OS / compiler you're using.
Comment From: madolson
Hey @icetech233, what all of these warnings have have in common is they are passing characters into system library functions, isspace() and is digit(), so I'm guessing on whatever system you are on they are what are throwing the warnings. I'm guessing they are implemented as macros, and not liking the char conversion. If you are running on a popular system, we might consider casting these to ints, but I don't think it's worth it.
Comment From: icetech233
@icetech233 please specify which OS / compiler you're using.
windows10 msys2 gcc
Comment From: oranagra
@icetech233 we generally don't intend to support this system, but if you can resolve the warnings and make a pull request we'll consider merging it.