Redis [NEW] XINFO GROUPS's "entries_read" should be "entries-read" for consistency

Comment From: oranagra

@itamarhaber do you mean the other way around? i don't see any string in the code starting with "entries_ i do wee entries-added, entries-read, last-delivered-id (all with hyphen). p.s some already existing before 7.0-RC1, e.g. last-generated-id

Comment From: enjoy-binbin

i guess it is mean https://redis.io/commands/xinfo-groups? this doc one indeed is an error (let me fix it)

entries_read: the logical "read counter" of the last entry delivered to group's consumers

the c code is ok:

            addReplyBulkCString(c,"entries-read");
            if (cg->entries_read != SCG_INVALID_ENTRIES_READ) {
                addReplyLongLong(c,cg->entries_read);
            } else {
                addReplyNull(c);
            }

Comment From: guybe7

@enjoy-binbin maybe it was already fixed? this is what I saw last time I checked:

> XINFO GROUPS mystream
1)  1) "name"
    2) "mygroup"
    3) "consumers"
    4) (integer) 2
    5) "pending"
    6) (integer) 2
    7) "last-delivered-id"
    8) "1638126030001-0"
    9) "entries_read"
   10) (integer) 2
   11) "lag"
   12) (integer) 0

Comment From: enjoy-binbin

Now in the unstable branch, the output is entries-read, the c file: https://github.com/redis/redis/blob/unstable/src/t_stream.c#L3903

127.0.0.1:6379> XINFO GROUPS mystream
1)  1) "name"
    2) "mygroup"
    3) "consumers"
    4) (integer) 0
    5) "pending"
    6) (integer) 0
    7) "last-delivered-id"
    8) "0-0"
    9) "entries-read"
   10) (nil)
   11) "lag"
   12) (integer) 1

Comment From: guybe7

@enjoy-binbin ok my bad, i guess i just looked at the example in redis-docs and assumed it came from an actual instance (but I guess it was edited manually) so yes, the fix is only in the docs