Redis [BUG] Sentinel test 08 can't run on its own

Describe the bug

Sentinel test 08-hostname-conf cannot be run on its own.

To reproduce

Compile Redis on Ubuntu 20.04, for example. ./runtest-sentinel --single 08-hostname-conf The test will fail because the procedure restart_killed_instances is missing.

Expected behavior

The test runs correctly.

Additional information

N/A

Comment From: enjoy-binbin

i see, we need to move source "../tests/includes/init-tests.tcl" to the top. it is a easy fix, let me fix it

Comment From: ivanstosic-janea

I suspected this but the test's name is pre-init ..., meaning that maybe it has to be run before init-tests.tcl?

Comment From: enjoy-binbin

yes, maybe. but i do test it without any errors, ping @yossigo i see other two options: 1. copy restart_killed_instances to the file (a easy fix) 2. move it to a new utils.tcl file, and source it in everywhere

Comment From: yossigo

@enjoy-binbin Option 2 is the better one IMHO. There are actually two procs that can be moved to utils. Do you want to handle that or shall I?

Comment From: enjoy-binbin

i can handle that (i remember i make a local fix for option 2), just let me do some tests later