Describe the bug
starting a sentinel using redis-server /path/to/sentinel.conf --sentinel fails.
To reproduce
root@d675e5f73c51:/data# touch /etc/redis/sentinel.conf
root@d675e5f73c51:/data# redis-sentinel /etc/redis/sentinel.conf --sentinel --bind 127.0.0.1 --port 26379 --dir "/data"
--sentinel announce-ip 127.0.0.1
*** FATAL CONFIG FILE ERROR (Redis 7.0.5) ***
Reading the configuration file, at line 2
>>> 'sentinel "--bind" "127.0.0.1"'
Unrecognized sentinel configuration statement.
Expected behavior
--sentinel should continue to work as before.
Additional information Worked in 6.x, doesn't work in redis:7.0.5 docker image
Comment From: enjoy-binbin
I suppose this will work, can you try? redis-sentinel /etc/redis/sentinel.conf --bind 127.0.0.1 --port 26379 --dir "/data"
Comment From: max06
It sure does - but it's an unannounced change. It forces us to modify our deployments to accomodate for this...
No issue with deprecating options if they're no longer required. But please with an announcement.
Edit: And if this was a planned change, I'd expect an update in the documentation 😄
Comment From: enjoy-binbin
Most of the time, we do have announcement. And we always try to avoid doing the breaking change.
i suppose it was an unintentional change, sorry for that. I will or others will go try trace the change. Will keep you update. And definitely will fix the doc if needed, thanks for the report
Comment From: max06
Such things happen, no worries. We worked around the issue on our end and are not blocked.
(I definitely wanted to sound less harsh than I did - sorry about that)
Comment From: enjoy-binbin
ok... i see, i am the one who break it, starting in #10660 and it also break - src/redis-server sentinel.conf --sentinel --sentinel - src/redis-sentinel sentinel.conf --sentinel --sentinel
i will try to think of a way, thanks for the report again.
@oranagra another unintentional change i made...
an easy way to fix it, is that we ignore all --sentinel in the options parse
Comment From: oranagra
i think we should handle it the same as we did for --save in #10866
i.e. it's a pseudo config option with no value.