Redis [BUG] CLIENT REPLY OFF|SKIP would disable push notifications

Describe the bug If client uses client reply off they will not get push notifications. If client uses client reply skip then they will not get push notifications until the next command's reply was skipped.

To reproduce

Client 1:

root@3ea0f2ab5df9:/bionic# telnet localhost 6379
Trying ::1...
Connected to localhost.
Escape character is '^]'.
hello 3
// ...

subscribe channel
// ...
client reply off

After that, if client 2 uses publish channel xyz then client 1 will not get any notifications.

This also works with client reply skip, but after client 1 sends another command, it will get notifications as usual.

Expected behavior CLIENT REPLY should only block command replies and not push notifications

Additional information Observed on Redis 7.0.5, might have existed before.

Comment From: enjoy-binbin

a simple patch seems to work https://github.com/redis/redis/commit/9ed1e193ef3f2b80442fbf324e23b7971fc8d5ea @oranagra WDYT?

Comment From: soloestoy

seems this is just a wrong usage, or if I miss something?

Comment From: oranagra

@soloestoy it may be an odd usage, but not sure a misuse. for instance a RESP3 client subscribed to KSN, or requested client side tracking on certain keys, now issues a command it doesn't want the reply for, so it uses SKIP but then misses some push messages as well (if some other client got executed between the SKIP and the next command of this client).