show complexity, blocking time, etc
Suggested additions: 1. Command complexity. 2. Blocking time 3. User that executed the command. 4. Database ID
Reference PRs: https://github.com/redis/redis/pull/6832, https://github.com/redis/redis/pull/12188
Comment From: hwware
hello @madolson , we are already displaying the "Client name if set via the CLIENT SETNAME command" . I can consolidate all other suggested addition as a part of one PR #12188 . If it is okay.
Comment From: madolson
. "Client name if set via the CLIENT SETNAME command"
Nice. I was just copying from PR headers.
Comment From: hwware
. "Client name if set via the CLIENT SETNAME command"
Nice. I was just copying from PR headers.
can I consolidate all of them in one PR ?
Comment From: madolson
@hwware I think this is low priority. I would rather bias towards keeping Redis simple. We had this argument in the past and it never went anywhere, so I'm not sure there are really needs from the community right now. I will consolidate all of the issues though.
Comment From: hwware
@hwware I think this is low priority. I would rather bias towards keeping Redis simple. We had this argument in the past and it never went anywhere, so I'm not sure there are really needs from the community right now. I will consolidate all of the issues though.
Sure thanks .
Comment From: judeng
Cool conclustion. There are all very useful information for us, and I want to share my two needs:
1. command complexity: In fact, we can easily memory that the complexity of the command is O(N) or O(LOG(N)+M) and so forth, what we want more is the complexity of the command in this key, for example, mget 20 keys, the complexity should be 20, and for zrangebyscore with a key have 100 elements and return 20 elements, its complexity should be log(100)+20
2. If dbid has a human readable name, it will be a sweet sweet sugar for users.
Comment From: judeng
Another request that may be too much is to display some command-related memory information in the slowlog. I can think of three memory data: command's input length, command's output length, key memory size (this will depend on #10472 as a precondition)