Describe the bug

exec ACL LIST display acl rule do not match the actual permissions

To reproduce

  1. ACL SETUSER user1 on >123 +config|get -config|set
  2. ACL SETUSER user1 +config
  3. ACL LIST ,

now user1 rule is "user user1 on sanitize-payload #a665a45920422f9d417e4867efdc4fb8a04a1f3fff1fa07e998e86f7f7a27ae3 resetchannels -@all -config|set +config"

now, use new redis client use user1 auth

  1. auth user1 123
  2. CONFIG SET slowlog-max-len 100

now reply "OK"

Expected behavior

after exec step 2 ACL SETUSER user1 +config, The acl rule at this time should be "user user1 on sanitize-payload #a665a45920422f9d417e4867efdc4fb8a04a1f3fff1fa07e998e86f7f7a27ae3 resetchannels -@all +config"

the -config|set should not show

From my understanding it should be like this

redis_version:7.1.242, Compile with unstable branch code

Comment From: madolson

Yeah, it looks like an odd interaction with how rules get compacted. +config should overwrite all the previous subcommand rules, but is only overwriting one of them.

Comment From: madolson

@roshkhatri Will take a look at this.

Comment From: lqxhub

Yeah, it looks like an odd interaction with how rules get compacted. +config should overwrite all the previous subcommand rules, but is only overwriting one of them.

thank you reply, I would like to participate fix the bug if possible

Comment From: madolson

@lqxhub Thanks for the offer and the report! I tried to look into it more to give you a place to start, and realized there was a more significant bug, so just went ahead and posted an update.

Comment From: lqxhub

@lqxhub Thanks for the offer and the report! I tried to look into it more to give you a place to start, and realized there was a more significant bug, so just went ahead and posted an update.

you cool; you are too efficient, describe in Chinese is 'niubi', I will continue to pay attention to redis in the future