Newest upgrade not completing:

pi@pihole:[~] $ sudo apt upgrade Reading package lists... Done Building dependency tree... Done Reading state information... Done Calculating upgrade... Done 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. 2 not fully installed or removed. After this operation, 0 B of additional disk space will be used. Do you want to continue? [Y/n] Setting up redis-server (6:7.2.4-1rl1~bookworm1) ... Job for redis-server.service failed because the control process exited with error code. See "systemctl status redis-server.service" and "journalctl -xeu redis-server.service" for details. invoke-rc.d: initscript redis-server, action "restart" failed. ● redis-server.service - Advanced key-value store Loaded: loaded (/lib/systemd/system/redis-server.service; enabled; preset: enabled) Active: activating (start) since Tue 2024-01-09 16:12:49 CET; 52ms ago Docs: http://redis.io/documentation, man:redis-server(1) Main PID: 18419 ((s-server)) Tasks: 1 (limit: 1595) CPU: 37ms CGroup: /system.slice/redis-server.service └─18419 "(s-server)"

Jan 09 16:12:49 pihole systemd[1]: Starting redis-server.service - Advanced key-value store... dpkg: error processing package redis-server (--configure): installed redis-server package post-installation script subprocess returned error exit status 1 dpkg: dependency problems prevent configuration of redis: redis depends on redis-server (<< 6:7.2.4-1rl1~bookworm1.1~); however: Package redis-server is not configured yet. redis depends on redis-server (>= 6:7.2.4-1rl1~bookworm1); however: Package redis-server is not configured yet.

dpkg: error processing package redis (--configure): dependency problems - leaving unconfigured Errors were encountered while processing: redis-server redis needrestart is being skipped since dpkg has failed E: Sub-process /usr/bin/dpkg returned an error code (1)

Comment From: un99known99

package enabled via https://packages.redis.io/deb bookworm InRelease

Comment From: yossigo

@un99known99 Can you follow the guidance to get more details:

See "systemctl status redis-server.service" and "journalctl -xeu redis-server.service" for details.

Comment From: un99known99

@yossigo I would need to re-apply backup as I reset to before the redis upgrade and did hide the sources file from apt atm

Comment From: un99known99

systemctl status redis-server.service:

pi@pihole:[~] $ sudo systemctl status redis-server.service × redis-server.service - Advanced key-value store Loaded: loaded (/lib/systemd/system/redis-server.service; enabled; preset: enabled) Active: failed (Result: exit-code) since Tue 2024-01-09 16:26:20 CET; 44s ago Docs: http://redis.io/documentation, man:redis-server(1) Process: 851 ExecStart=/usr/bin/redis-server /etc/redis/redis.conf (code=exited, status=1/FAILURE) Main PID: 851 (code=exited, status=1/FAILURE) CPU: 590ms

Jan 09 16:26:20 pihole systemd[1]: redis-server.service: Scheduled restart job, restart counter is at 5. Jan 09 16:26:20 pihole systemd[1]: Stopped redis-server.service - Advanced key-value store. Jan 09 16:26:20 pihole systemd[1]: redis-server.service: Start request repeated too quickly. Jan 09 16:26:20 pihole systemd[1]: redis-server.service: Failed with result 'exit-code'. Jan 09 16:26:20 pihole systemd[1]: Failed to start redis-server.service - Advanced key-value store.

Comment From: un99known99

seems I found the error: I changed logfile to /var/log/redis.log so now I changed ReadWriteDirectories=-/var/log/redis to ReadWriteDirectories=-/var/log in redis-server.service, that solved it

Comment From: un99known99

seems update changed my service settings back, the upgrade did reset my changed config in terms of /var/log

Comment From: yossigo

Local systemd unit files should be modified with systemctl edit, which should prevent this from happening in the future.

Comment From: un99known99

thx for the info @yossigo

Comment From: un99known99

@yossigo : sudo /usr/bin/redis-check-aof /var/lib/redis/appendonlydir/appendonly.aof.manifest still gives 7.2.3

Start checking Multi Part AOF Start to check BASE AOF (RDB format). [offset 0] Checking RDB file /var/lib/redis/appendonlydir/appendonly.aof.1.base.rdb [offset 26] AUX FIELD redis-ver = '7.2.3' [offset 40] AUX FIELD redis-bits = '32' [offset 52] AUX FIELD ctime = '1701349097' [offset 67] AUX FIELD used-mem = '710136' [offset 79] AUX FIELD aof-base = '1' [offset 88] Checksum OK [offset 88] \o/ RDB looks OK! \o/ [info] 0 keys read [info] 0 expires [info] 0 already expired RDB preamble is OK, proceeding with AOF tail... AOF analyzed: filename=appendonly.aof.1.base.rdb, size=88, ok_up_to=88, ok_up_to_line=1, diff=0 BASE AOF appendonly.aof.1.base.rdb is valid Start to check INCR files. AOF analyzed: filename=appendonly.aof.1.incr.aof, size=302335, ok_up_to=302335, ok_up_to_line=21572, diff=0 INCR AOF appendonly.aof.1.incr.aof is valid All AOF files and manifest are valid