Describe the bug
Slave node attached to a slave node instead of a master node during upgrade.
To reproduce
- Create a new Redis node
- Attach Redis node to an existing master using CLUSTER REPLICATE
- Right when CLUSTER REPLICATE is executing Failover the said master so it is now a slave
Expected behavior The newly attached slave should be the slave for the new master instead of the old master which is a slave now.
Additional information
Redis server info (same for all nodes)
old-redis-node:/data$ redis-cli info server
# Server
redis_version:7.0.12
redis_git_sha1:00000000
redis_git_dirty:0
redis_build_id:275d31c4087c801
redis_mode:cluster
os:Linux 5.15.131.1-2.cm2 x86_64
arch_bits:64
monotonic_clock:POSIX clock_gettime
multiplexing_api:epoll
atomicvar_api:c11-builtin
gcc_version:12.2.0
process_id:15
process_supervised:no
run_id:d5776a7bec7f7d96b3a160bb4fcc7fea7c3b2264
tcp_port:6379
server_time_usec:1706440690803980
uptime_in_seconds:131692
uptime_in_days:1
hz:10
configured_hz:10
lru_clock:11941874
executable:/data/redis-server
config_file:/redis-conf/redis.conf
io_threads_active:0
Replication info from the newly attached slave pov
new-redis-slave:/data$ redis-cli cluster nodes
976c785dcc9ef08cdc3083598c286bcbf95fb01f 192.168.3.145:6379@16379 myself,slave c8e441d4d6d69c94e2eab74ddb39e29a70d277d5 0 1706439383000 127 connected
d5f97b1fab87d11389a5de1c76acfc8748ecabfc 192.168.5.210:6379@16379 slave 55dd6ef25618c8da767217744c00f87f64f0099b 0 1706439388367 116 connected
edd3ed6d4a2301d4712cb0facc8e6b78b4d94835 192.168.4.239:6379@16379 slave ec38582b7e3032fb0b5113d654e51f59b67ae706 0 1706439387000 112 connected
0e1999febc2b6d02c39c675c6959ec3c2f48c5cf 192.168.2.100:6379@16379 slave 3c69aa1f69d5eff460195669168a9c8fb0835114 0 1706439384000 122 connected
c8e441d4d6d69c94e2eab74ddb39e29a70d277d5 192.168.1.171:6379@16379 slave 3c69aa1f69d5eff460195669168a9c8fb0835114 0 1706439388000 122 connected
80f30f99160153a31f943f0322b77c2faceb698d 192.168.5.211:6379@16379 slave 2d01e4947cb903c306819888675998762621397b 0 1706439388000 117 connected
7e57bb96b59c3c00392fab12e341c91331cbff38 192.168.1.169:6379@16379 slave ec38582b7e3032fb0b5113d654e51f59b67ae706 0 1706439387000 112 connected
73586a8905a09508f56193621f18f99f8d763c7a 192.168.3.144:6379@16379 master - 0 1706439388869 121 connected 0-3276
3c69aa1f69d5eff460195669168a9c8fb0835114 192.168.1.170:6379@16379 master - 0 1706439386358 122 connected 5462-8738
7b9ee923858e39182e706ef03ac14f2833322396 192.168.1.172:6379@16379 slave c8e441d4d6d69c94e2eab74ddb39e29a70d277d5 0 1706439386559 127 connected
55dd6ef25618c8da767217744c00f87f64f0099b 192.168.3.143:6379@16379 master - 0 1706439388000 116 connected 4371-5461 8739-10923
2d01e4947cb903c306819888675998762621397b 192.168.4.241:6379@16379 master - 0 1706439387363 117 connected 10924-14200
16bbeb514999a54b18a07887fe0186319add364f 192.168.5.209:6379@16379 slave 55dd6ef25618c8da767217744c00f87f64f0099b 0 1706439389371 116 connected
0f434b51a03583c2685a418da93e7b2c65a5498e 192.168.2.98:6379@16379 slave 73586a8905a09508f56193621f18f99f8d763c7a 0 1706439386000 121 connected
cc950a1a974cabd4870b87b0a1ba8abf72ef4a87 192.168.4.242:6379@16379 slave 2d01e4947cb903c306819888675998762621397b 0 1706439387000 117 connected
ec38582b7e3032fb0b5113d654e51f59b67ae706 192.168.4.240:6379@16379 master - 0 1706439389572 112 connected 3277-4370 14201-16383
cb65167898c7273ef89f4ef96b31e8d754e68974 192.168.2.99:6379@16379 slave 73586a8905a09508f56193621f18f99f8d763c7a 0 1706439386000 121 connected
new-redis-slave:/data$ redis-cli info replication
# Replication
role:slave
master_host:192.168.1.171
master_port:6379
master_link_status:up
master_last_io_seconds_ago:2
master_sync_in_progress:0
slave_read_repl_offset:43531741987
slave_repl_offset:43531741987
slave_priority:100
slave_read_only:1
replica_announced:1
connected_slaves:0
master_failover_state:no-failover
master_replid:43e279cc982d9f477fc3c6ad7b70b7f4af09d576
master_replid2:0000000000000000000000000000000000000000
master_repl_offset:43531741987
second_repl_offset:-1
repl_backlog_active:1
repl_backlog_size:209715200
repl_backlog_first_byte_offset:43322020819
repl_backlog_histlen:209721169