Comment From: spencergibb
Did you target the wrong branch?
Comment From: snicoll
@wanderleisouza thanks for the PR.
Thanks @spencergibb, wrong branch indeed. I've fixed that and we can decide where to target this when we review/polish the PR.
Comment From: wanderleisouza
oh, thank you @snicoll and @spencergibb. I think it should be in 2.3.x, no? Let me know how to proceed (notice concourse-ci/status is broken due to boot:checkstyleTest). Should I submit a new PR?
Comment From: snicoll
I think it should be in 2.3.x, no?
As I've already indicated we can merge the PR in the appropriate branches as part of reviewing the PR.
notice concourse-ci/status is broken due to boot:checkstyleTest). Should I submit a new PR?
Ideally you should have built the project locally before submitting the PR, which would have revealed the build failure. We can also take care of that as part of reviewing.
Please don't open a new PR as it'd create unnecessary noise. FYI, pushing additional changes to your existing branch will update this PR.
Comment From: snicoll
@wanderleisouza thank you for making your first contribution to Spring Boot. I've polished it and applied to both 2.3.x and master.
I've reworked the tests in particular as the assertions were not running properly. It can be tricky with assertJ but the assertion should run "outside" of the main thing to assert. So assertThat(errorAttributeOptions.getIncludes().isEmpty()); should have been assertThat(errorAttributeOptions.getIncludes()).isEmpty();. This assertion was wrong for the include use case so I've fixed that too.