It seems that the following line in Md4PasswordEncoder is redundant:
https://github.com/spring-projects/spring-security/blob/1e211b6558f558a465d3653c38cd5d46694226be/crypto/src/main/java/org/springframework/security/crypto/password/Md4PasswordEncoder.java#L86
Comment From: rwinch
It is not clear to me what you mean. Can you provide more details?
Comment From: justmehyp
@rwinch Sorry that I didn't make it clear at one time. When I read the source code of class org.springframework.security.crypto.password.Md4PasswordEncoder, I guessed that it was implemented by org.springframework.security.crypto.password.Digester, but I found that private Digester digester; was defined in class Md4PasswordEncoder, but it was never used. So I think this line of code is redundant, and could be removed.
Comment From: justmehyp
This is my PR related to this issue: https://github.com/spring-projects/spring-security/pull/8553
Comment From: rwinch
Thanks for the PR! I'm closing this a duplicate of the PR