Expected Behavior OAuth2ClientPropertiesRegistrationAdapter.getBuilderFromIssuerIfPossible should validate that issuer is not blank Because few lines after, code throws exception if this issuer is null or emptyString or blankString

Current Behavior OAuth2ClientPropertiesRegistrationAdapter.getBuilderFromIssuerIfPossible validates that issuer is not null

Context

class OAuth2ClientPropertiesRegistrationAdapter {
  ...
  private static Builder getBuilderFromIssuerIfPossible(...) {
      ...
      if (issuer != null) {  // this code performs only null check
        Builder builder = ClientRegistrations.fromIssuerLocation(issuer).registrationId(registrationId);
        return getBuilder(builder, provider);
      }
      ...
  }
  ...
}

public static ClientRegistration.Builder fromIssuerLocation(String issuer) {
  Assert.hasText(issuer, "issuer cannot be empty"); // this code perform null check + String content check
  ...
}

Comment From: marcusdacoregio

Hi @bitxon, thank you for reaching out.

Since the OAuth2ClientPropertiesRegistrationAdapter class is from Spring Boot, can you open the issue on its repository?

Comment From: bitxon

Hi @bitxon, thank you for reaching out.

Since the OAuth2ClientPropertiesRegistrationAdapter class is from Spring Boot, can you open the issue on its repository?

Hello, I have created a new issue in spring-boot repo: https://github.com/spring-projects/spring-boot/issues/28139

Comment From: marcusdacoregio

Thanks, @bitxon. Closing this in favour of https://github.com/spring-projects/spring-boot/issues/28139