Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24568
Comment From: snicoll
Very nice @martindacos. Thank you for making your first contribution to Spring Boot.
Comment From: martindacos
Happy to help @snicoll ! It's fine the way that I did to create the PR and the branch? I was reading the contributing guide but I didn't found any example, can you point me to the documentation for the future?
Thanks
Comment From: snicoll
Usually you'd create first a branch from your clone (rather than doing the changes directly on master) which is a general recommendation when submitting a PR, nothing Spring Boot specific. Other than that, it was very good yes. I did polish the contribution because the property has a default value in Spring Kafka and I wanted to make sure it is advertized properly in the metadata.
I think the contributing page describes the things that are Spring Boot specific. If you believe differently, feel free to create an issue or another PR.
Comment From: martindacos
Alright, thank you
Comment From: garyrussell
@snicoll Please note that the default is now true in 2.7.0-SNAPSHOT: https://github.com/spring-projects/spring-kafka/commit/62046c299fd9783b01e866076176d5e2a0a23d60
Comment From: snicoll
Thank you Gary, I was subscribed to this issue. We have a test to check the consistency of the default that'll fail once we switch.