Comment From: tawAsh1
Almost LGTM. We also checked the behavior. I was looking at other methods like setAllowUrlEncodedPercent(), how about adding setAllowUrlEncodedCRLF() with the appropriate warning document?
Comment From: rwinch
@tawAsh1 Thank you for your feedback.
User's can always invoke getEncodedUrlBlocklist and getDecodedUrlBlocklist which allow adding and removing characters from it. The allow methods are for convenience for URL values that we felt were more likely to want to be enabled. I did not consider newlines to be likely for users to want to add/remove. However, since you requested the convenience methods, I went ahead and added them in e2eed33eca21451eadf23aeeeea31a9ede4dbeb5 Please let me know if this looks good to you.
Comment From: tawAsh1
LGTM! Thanks.