Added autoconfig support and tests for the elastic search sniffer.
Comment From: somayaj
Thanks for the feedback. I believe all of the changes requested are in place now.
Comment From: snicoll
I believe all of the changes requested are in place now.
Unfortunately, 4 of the 5 tests you've added are still failing for me. It might be because you don't have docker running locally and the tests are skipped for you (see @Testcontainers(disabledWithoutDocker = true) at the top of the test class).
Thank you very much for the follow-up and the feedback on the reviews. Unfortunately, there are quite a lot of pieces that still need more work and I've decided to take over. Please review https://github.com/spring-projects/spring-boot/commit/1fd17cf641ad011a7395b88e65f30c2a4596cb23 for more details. Thanks for the PR, in any case!
Comment From: somayaj
Thanks for considering.
Regards, Asha
On Wed, Dec 23, 2020 at 10:15 AM Stéphane Nicoll notifications@github.com wrote:
I believe all of the changes requested are in place now.
Unfortunately, 4 of the 5 tests you've added are still failing for me. It might be because you don't have docker running locally and the tests are skipped for you (see @Testcontainers(disabledWithoutDocker = true) at the top of the test class).
Thank you very much for the follow-up and the feedback on the reviews. Unfortunately, there are quite a lot of pieces that still need more work and I've decided to take over. Please review 1fd17cf https://github.com/spring-projects/spring-boot/commit/1fd17cf641ad011a7395b88e65f30c2a4596cb23 for more details. Thanks for the PR, in any case!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-boot/pull/24340#issuecomment-750369544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRAZGKMLHLFB4Q4JHAUJW3SWIJTTANCNFSM4UOVTK2Q .