jOOQ introduced following new providers. Auto-configuration should be able to pick them up a and put into jOOQ configuration. This pull request makes it happen.
New providers added to JooqAutoConfiguration:
DiagnosticsListenerProviderUnwrapperProviderCharsetProviderConverterProvider
Thank you for reviewing this PR.
Comment From: pivotal-issuemaster
@vkuzel Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@vkuzel Thank you for signing the Contributor License Agreement!
Comment From: lukaseder
I wonder if this discovery could be automated. All of these auto-configuration candidates are always located in org.jooq.Configuration...
Comment From: snicoll
Given the number of callbacks I am also considering a different approach. Perhaps a DefaultConfigurationCustomizer would be a better fit as I don't think these need to be exposed as beans for other purposes. If so, it feels a bit odd to me that we'd have to register so many beans potentially just for the purpose of the auto-configuration to find them.
Flagging for team attention to see what the rest of the team thinks.
Comment From: snicoll
@vkuzel thank you for the PR and for letting us know about those new callbacks in jOOQ. We've discussed this and decided to fix this in a different way (#24732). Thanks again.