Spring Security Spring Security Doc: clientName should be name of the Application instead of the Authentication Provider

In https://docs.spring.io/spring-security/reference/servlet/oauth2/login/core.html

@Configuration
public class OAuth2LoginConfig {

...

    private ClientRegistration googleClientRegistration() {
        return ClientRegistration.withRegistrationId("google")
...
            .clientName("Google")
            .build();
    }
}

my understanding is that "Google" is not the client, but the authentication provider. So maybe clientName should be something like "MyApplication".

Comment From: sjohnr

@Upamo thanks for the suggestion. However, it seems you may be misunderstanding the purpose of the ClientRegistration. Imagine a login page with username/password fields and a set of "Log in with..." links. Each link would point to a particular provider. In this case, it would be "Log in with Google". So "Google" is the name of the provider referred to by the ClientRegistration.

I'm going to close this issue with the above explanation, but let me know if I missed something from your request.

Comment From: Upamo

Hi Steve, thanks a lot for your clarification. That totally makes sense. I was confused by the property name "clientName" because from my understanding the application is the client and the authorization server is the server. But I see that it makes no sense to put the name of my application there. Kind regards Bernhard

Am Do., 28. Sept. 2023 um 18:07 Uhr schrieb Steve Riesenberg ***@***.***:

@Upamo https://github.com/Upamo thanks for the suggestion. However, it seems you may be misunderstanding the purpose of the ClientRegistration. Imagine a login page with username/password fields and a set of "Log in with..." links. Each link would point to a particular provider. In this case, it would be "Log in with Google". So "Google" is the name of the provider referred to by the ClientRegistration.

I'm going to close this issue with the above explanation, but let me know if I missed something from your request.

— Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-security/issues/13848#issuecomment-1739621478, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANZCKKBLBDQBKFSXTH2OLXTX4WOCRANCNFSM6AAAAAA46IOXGE . You are receiving this because you were mentioned.Message ID: @.***>