Hi guys, when I ran code analyzer on the repo, I found some minor spots that can be tweaked. However, before creating a PR, I'd like to ask if this is something that is welcomed assuming the changes aren't that many and do not have any negative impact on the existing code.
Tweaks examples: 1- Reducing memory fingerprint. 2- Adding null validations. 3- Reduce string concatenations (if present). 4- Other minor tweaks.
If this is welcomed, then I'd be happy to make a pull request, and I'm open to discussing the changes.
Comment From: sjohnr
Hi @mosbat!
I'd like to ask if this is something that is welcomed
Thanks for getting in touch, but it feels like this is a question that would be better suited to Stack Overflow. We prefer to use GitHub issues only for bugs and enhancements.
Having said that, you are of course free to submit PRs. See CONTRIBUTING.adoc for more information.
Adding null validations.
Please keep in mind this could potentially be a breaking change in some cases, so cases where needed null checks are missing should be relatively few. Please also try to keep PRs focused on one improvement at a time.
I'm going to close this issue as answered.
Comment From: mosbat
Hi @mosbat!
I'd like to ask if this is something that is welcomed
Thanks for getting in touch, but it feels like this is a question that would be better suited to Stack Overflow. We prefer to use GitHub issues only for bugs and enhancements.
Having said that, you are of course free to submit PRs. See CONTRIBUTING.adoc for more information.
Adding null validations.
Please keep in mind this could potentially be a breaking change in some cases, so cases where needed null checks are missing should be relatively few. Please also try to keep PRs focused on one improvement at a time.
I'm going to close this issue as answered.
Thank you, appreciate responding to me. I'll see if I could use your Stack overflow channel!
Kind regards!