Hi, this is a first-timers-only
issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
If you have contributed before, consider leaving this one for someone new, and looking through our general ideal-for-contribution
issues. Thanks!
Problem
Detection of MariaDB in org.springframework.boot.jdbc.DataBaseDriver is incorrect. The MariaDB driver returns MariaDB
as the productName
but we are using MySQL
as the productName
.
Solution
Update the DatabaseDriver
enum with the right value for the productName
for MariaDB
.
Update the tests to ensure that the right DatabaseDriver.fromProductName()
works for MariaDB
.
Steps to Fix
- [ ] Claim this issue with a comment below and ask any clarifying questions you need
- [ ] Set up a repository locally following the Contributing Guidelines
- [ ] Try to fix the issue following the steps above
- [ ] Commit your changes and start a pull request.
Comment From: anudeepg
I am interested to contribute, Can I claim this issue ?
Comment From: scottfrederick
@anudeepg I've assigned the issue to you. Please let us know if you have any questions. Note that the issue is assigned to the 2.3.x
milestone, so you should submit a pull request against that branch. We'll take care of merging the changes forward to newer versions when merging the PR.
Comment From: anudeepg
Thanks for encouraging first-timers, I am just checking out code & following contribution guidelines. Sure I will raise the PR accordingly.
Comment From: snicoll
Closing in favor of PR #25173