$ brew install springboot.rb
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/cask).
==> Updated Casks
Updated 1 cask.
Error: No available formula with the name "springboot".
In formula file: /Users/awilkinson/dev/temp/spring-boot-tap-2.4.3/springboot.rb
Expected to find class Springboot, but only found: SpringBoot.
I think we need to rename the class to Springboot. Hopefully this will continue to work with Homebrew 2.x as well.
Comment From: wilkinsona
Trying out the rename:
$ brew install springboot.rb
Error: Failed to load cask: springboot.rb
Cask 'springboot' is unreadable: wrong constant name #<Class:0x00007fea261681a0>
Warning: Treating springboot.rb as a formula.
Comment From: dreis2211
Isn't this now, spring-boot.rb (with a dash) @wilkinsona ? See #24659
Comment From: wilkinsona
Aah, perhaps it is. Thanks, @dreis2211. We may need an update to the release checklist in that case.
Comment From: wilkinsona
That's certainly better. It does still complain a bit though:
Error: Failed to load cask: spring-boot.rb
Cask 'spring-boot' is unreadable: wrong constant name #<Class:0x00007fb53818b218>
Warning: Treating spring-boot.rb as a formula.
I don't recall seeing those with Homebrew 2.7 so I'm not sure if there's something else that needs to be tweaked.
Comment From: philwebb
Strange. I intentionally renamed it so user accessing the old version would get a migration message. I'm pretty sure I tested it as well.
Comment From: wilkinsona
This works without any warnings or errors being logged:
brew install --formula spring-boot.rb
Comment From: wilkinsona
I think the - throws it off and makes it try it as a Cask first. That fails so it then has a go as a Formula. I'm not sure if this only matters when we're verifying the tap or if it'll cause problems for users.
Comment From: philwebb
Running with the tap added gives:
➜ $ brew install spring-boot
==> Installing spring-boot from spring-io/tap
==> Downloading https://repo.spring.io/release/org/springframework/boot/spring-boot-cli/2.4.2/spring-boot-cli-2.4.2-bin.tar.gz
######################################################################## 100.0%
==> Caveats
zsh completions have been installed to:
/usr/local/share/zsh/site-functions
==> Summary
🍺 /usr/local/Cellar/spring-boot/2.4.2: 7 files, 13.2MB, built in 4 seconds
➜ $ brew --version
Homebrew 3.0.1
Homebrew/homebrew-core (git revision 3ab9e85; last commit 2021-02-18)
Homebrew/homebrew-cask (git revision d82d0; last commit 2021-02-18)
Comment From: philwebb
So I think it might just be the release instructions for testing that need to be updated.
Comment From: wilkinsona
Thanks, Phil. I've pushed some updates to the checklist.