Spring Cloud Openfeign @FeignClient properties are not interpolated correcty

Describe the bug Properties are not interpolated correcty, for example:

@FeignClient(....., url = "${my.feign.client.url}") ...

and in application.properties if we define:

# for backwards compatibility
my.feign.client.url=${legacy.property.name} 

This results in:

Caused by: java.lang.IllegalArgumentException: Could not resolve placeholder 'my.feign.client.url' in value "http://${legacy.property.name}"

Or an error while trying to make requests with the client because the URL is wrong..

This seems to be due to:

https://github.com/spring-cloud/spring-cloud-openfeign/blob/master/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientsRegistrar.java#L108-L110

The workaround to this is to define the property in application.properties as:

my.feign.client.url=#{'${legacy.property.name}'}

Comment From: OLPMO

Could you provide a minimal demo to reproduce the bug?

Comment From: spencergibb

I don't think it ever worked did it?

Comment From: spring-projects-issues

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Comment From: spring-projects-issues

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.