add autoconfiguration for bolt driver, including tests
gh-6690
Comment From: vince-bickers
should probably also take this opportunity to add support for https as well?
Comment From: snicoll
@vince-bickers not in this issue, no. Feel free to create a separate PR for that.
Comment From: xenoterracide
let me know if I need to make any changes to the code/commits before they can be merged.
Comment From: snicoll
I remember why I didn't support bolt
in 1.4.0
. It is a Neo4j 3.0.0 specific thing and it wasn't available at the time we implemented the feature.
@xenoterracide I am a bit confused. I see no indication in your PR that Spring Boot provides dependency management for the bolt driver. We don't have dependency management for neo4j-java-driver
which looks suspicious to me. It isn't used anywhere in the codebase, not even in a sample. What did you add to your own project to use it?
Comment From: snicoll
I changed my mind. The bolt URL parsing has been merged in master. Regarding the detection of the bolt driver and the behaviour change, we can't do that in a bug fix release. Feel free to submit another issue for 1.5 but if you do, I'd like to get more details (per my previous comment). Thanks for the PR.