seems we only support readTimeout for okhttp, Can we support readTimeout for FeignAutoConfiguration:HttpClientFeignConfiguration:httpClient?

I just noticed we actually have per-request-default options which override the httpClient-default value:

public Options() {
  this(10, TimeUnit.SECONDS, 60, TimeUnit.SECONDS, true);
}

so I can use this as a workaround, but still want the httpClient level readTimeout :)

Comment From: OlgaMaciaszek

HttpClientBuilder does not provide readTimeout property, however we could add setting socketTimeout and connectionRequestTimeout.

Comment From: jas34

@OlgaMaciaszek if this is still needed to be worked upon then I would like to work on this.

Comment From: OlgaMaciaszek

Hi @jas34, sure :). We are not planning to be adding many enhancements to this project anymore, since we've moved it into maintenance mode, but if you'd like to create a PR for this, we will review it.

Comment From: jas34

@OlgaMaciaszek I can see: 1. socketTimeout is already existing in https://github.com/spring-cloud/spring-cloud-openfeign/blob/07ded06f73f62ea2b74ad096db31ce2cab873f4d/spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/clientconfig/HttpClient5FeignConfiguration.java#L81 2. connectionRequestTimeout was added in PR https://github.com/spring-cloud/spring-cloud-openfeign/pull/817

I do not think anything is needed against this ticket. Let me know if something is additionally expected.

Comment From: OlgaMaciaszek

Right, it seems it was done in the meantime. Sorry for the confusion @jas34. Feel free to pick a different issue if you would like to add another contribution.

Comment From: OlgaMaciaszek

Closing as already done.

Comment From: x-iron

Hi @jas34, sure :). We are not planning to be adding many enhancements to this project anymore, since we've moved it into maintenance mode, but if you'd like to create a PR for this, we will review it.

Hi @OlgaMaciaszek , do you mean this project (spring cloud openfeign) is in maintenance mode now?

Comment From: OlgaMaciaszek

Hi @x-iron, yes, we've announced it as feature-complete. We suggest Spring Interface Clients as a replacement going forward.