Describe the bug
I have 2 implementations of ResponseInterceptor, both fail to trigger in 4.1.0. If I remove one of them, then it works.
@Component
public class AuditorGatewayResponseInterceptor implements ResponseInterceptor {
//// removed
}
@Component
public class AnotherResponseInterceptor implements ResponseInterceptor {
//removed
}
Comment From: OlgaMaciaszek
Hello @marcdv, thanks for creating an issue. Please provide a minimal, complete, verifiable example that reproduces the issue, as a link to a GitHub repo with an executable app or tests.
Please learn how to properly format code and logs.
Comment From: spring-cloud-issues
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.
Comment From: galaxy-sea
hello @marcdv , see gh-1003
Comment From: marcdv
Please review https://github.com/marcdv/testFeign for an example
Steps to reproduce
-
Start the server
gradle bootrun -
call the API
GET http://localhost:8080/api/test -
Review logs in console (note no logs)
-
Comment out line 10 (@Component) in AResponseInterceptor.java
-
Restart the server
-
Call the API as above
-
Review logs (note BResponseInterceptor was called)
Comment From: OlgaMaciaszek
Thanks, @marcdv. That's actually never been supported and also the docs only show a way to provide one interceptor, so this would be an enhancement. Since this project is now in maintenance mode (suggested replacement: Spring Interface Clients), we are not planning on adding new features ourselves, but we still review small community PR. I see @galaxy-sea has submitted a PR for this, but it has breaking changes, so can only be considered for a major release and I will mark it as such, however at this point it has not been decided if there will be another major of this project.
Comment From: LouisXhaferi
Hey @OlgaMaciaszek 👋🏻 , just asking, as I've seen you mention that spring-cloud-openfeign is now under maintenance mode a couple of times:
Could you maybe point me to Docs where this is explained? Would it make sense to add this info to the Repo Readme?
Thanks in advance :)
P.S.: The link above to the Spring Interface Clients does not seem to work!
Comment From: askingcat
Here a fixed linked: Spring Interface Clients.
Comment From: OlgaMaciaszek
Hi @askingcat . That's strange. The link works for me. Can you please try it again (maybe the site was temporarily down)? Here it is, in the warning section: https://docs.spring.io/spring-cloud-openfeign/reference/
Comment From: LouisXhaferi
Thank you for sharing that link! :)
Still off-topic, but regarding the link to the Spring Interface Client Docs:
Nope, still can't see it. But also, when I drill down to the list of releases at https://docs.spring.io/spring-framework/docs/
I found no entry for 6.0.6-SNAPSHOT, as used in the url, but there is one for 6.0.x-SNAPSHOT, so that might be a reason 🤷🏻
@askingcat's link points to 6.0.6 so that obviously works.
Comment From: OlgaMaciaszek
Thanks @LouisXhaferi, right, possibly something cached on my end. This should work: https://docs.spring.io/spring-framework/reference/integration/rest-clients.html#rest-http-interface