Describe the bug
Config server always return UP
after reset remote github uri credentials.
Sample
Reproduce step
* Create one config server with github public uri https://fake-uri.git
* Curl /actuator/health, should be UP
here.
* Make the https://fake-uri.git repo privated.
* Curl /actuator/health, should be DOWN
then but still get UP
as usual.
Potential Fix Throw exception when fetch() invoked by refresh(). Thus when fetch failure, refresh should be aware of this. https://github.com/spring-cloud/spring-cloud-config/blob/baa1bd4282c753a39c5a019cef6efba7a9f06f66/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/JGitEnvironmentRepository.java#L451-L475
Comment From: spencergibb
actuator health calls are cached for a while. Have you tried waiting?
Comment From: Incarnation-p-lee
Yes, I didn't config endpoints.health.time-to-live
thus it should be 1 seond.
I setup one simple config server locally with curl to verify many times and reproduce stablely. So it may not related to cache from my side.
Comment From: Incarnation-p-lee
any update about this issue ?
Comment From: spencergibb
I think this is expected behavior. In my test, the local checkout of the git repository is still there, so that it what it uses.
Comment From: spring-cloud-issues
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.
Comment From: spring-cloud-issues
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.