Dear Spring Boot Team,
I'm just reading the documentation carefully, although I'm not a native English speaker, I still think the word any
should be all
in the following statement,
- An ApplicationReadyEvent is sent after
any
application and command-line runners have been called.
It's in the 1.7. Application Events and Listeners section.
By checking the code of SpringApplication, in method callRunners
, after all application runners or command line runners being called, listeners.running(context)
will trigger the ApplicationReadyEvent
, therefore, I think it's better using "all" in the documentation instead of "any".
It's not a critical issue but I think it's better to fix it, especially for the non-English speakers.
Please kindly consider it. Thank you!
Comment From: dipengfei
Привет, на каком языке ты общаешься?
Hi, I come from China, my mother tongue is Chinese, but I can speak English.
Thank you.
Comment From: snicoll
@Fradulentus the issue tracker is not a forum and we communicate in English. If you have a question, please ask it on Stack Overflow or come chat with us on Gitter.
Comment From: snicoll
@dipengfei I believe that "any" in that context meant to emphasis that there might be none. So the event is fired after they are called, if any. We'll have a look and check if we can make that a bit more explicit.
Comment From: dipengfei
@snicoll Thanks for your clarification, and it's nice to make it more explicit.
Comment From: snicoll
@wilkinsona and I discussed a few options and none of them felt satisfactory. We also use any
in other places with the same meaning. Given that the current sentence is correct, I am afraid there's not much else we can do. Thank for the suggestion and for raising the issue, in any case!
Comment From: dipengfei
@snicoll Thank you very much for the actions, and I'm ok for it.