I think the minimum mpl version should be bumped to 3.6.1 for the 1.5.x releases too
It's true that the ci/deps/actions-38-minimum_versions.yaml
run would pin matplotlib to 3.3.2
, and that would pass, but the docstrings were getting tested with matplotlib 3.6.2
because matplotlib
wasn't pinned in environment.yml
So MPL 3.3.2 was never really supported to begin with in 1.5.x, it only looked like it was because some tests were being run with MPL 3.6.2
Shall we just bump it?
cc @phofl
Comment From: MarcoGorelli
Actually, this can be fixed without bumping the minimum version, looks like it's just the formatting of the output that's changed:
2022-12-12T19:49:33.0593335Z Expected:
2022-12-12T19:49:33.0593686Z <AxesSubplot: ylabel='Density'>
2022-12-12T19:49:33.0593964Z Got:
2022-12-12T19:49:33.0594285Z <AxesSubplot:ylabel='Density'>
Maybe just putting >=3.6.1
in environment.yml
is enough then, will try