Pandas version checks
-
[X] I have checked that this issue has not already been reported.
-
[X] I have confirmed this bug exists on the latest version of pandas.
-
[ ] I have confirmed this bug exists on the main branch of pandas.
Reproducible Example
import pandas as pd
a = pd.Series([0, np.nan], dtype="float")
b = pd.Series([0, 1], dtype="Int64")
(a * b).sum()
Issue Description
According to https://pandas.pydata.org/docs/dev/user_guide/missing_data.html#calculations-with-missing-data, missing data should be treated as 0 when calculating the sum, while the code above yields np.nan
.
When constructing a Series
with dtype="Float64"
, np.nan
is converted to pd.NA
. In the code above, the type of a * b
is inferred as Float64
, but np.nan
persists.
Expected Behavior
returns 0
Installed Versions
Comment From: attack68
On the main branch I can't verify this, I get:
import pandas as pd
a = pd.Series([0, np.nan], dtype="Float64")
b = pd.Series([0, 1], dtype="Int64")
(a * b).sum()
0.0
Comment From: rhshadrach
@attack68 - "float" in line 2, not "Float64". With that change, I also get nan
which looks incorrect to me.
Comment From: attack68
But isn't that the point of this issue. OP is reporting that with either "float" or "Float64" he gets "nan", but that he is expecting to get 0 only in the case of "Float64", which seems to be as described in the docs he links? And I'm suggesting that on main this all works as he expects. Maybe I misunderstand.
Comment From: rhshadrach
OP is reporting that with either "float" or "Float64" he gets "nan"
I don't think that's the case. I believe OP is saying that doing [float] * [Int64]
the dtype gets coerced to Float64
, but containing the value np.nan
(rather than coercing to the expected pd.NA
). With this, doing the sum then gives the value np.nan
rather than the expected 0
.
which seems to be as described in the docs he links?
The docs say When summing data, NA (missing) values will be treated as zero.
So with the dtype being float
in your line 2 above, shouldn't the result here be 0?
Comment From: jorisvandenbossche
I think this is essentially the same issues as https://github.com/pandas-dev/pandas/issues/42630 (but for a different operation). When mixing a nullable and non-nullable column in element-wise operations such as multiplication, we should ensure to convert the non-nullable column to a nullable dtype, so np.nan gets converted to pd.NA, and the element-wise operation (and also subsequent sum) proceeds as expected.
Comment From: dimitra-karadima
Hello all! I would like to try to tackle this issue. I am new to contributing to pandas so if you have any suggestions or a high-level specification in mind please let me know!
Comment From: attack68
Hello all! I would like to try to tackle this issue. I am new to contributing to pandas so if you have any suggestions or a high-level specification in mind please let me know!
this is quite a complicated issue. i would suggest you find an issue labelled "good first issue" or "contributions welcome". that will help you explore the code and learn the PR and approvals process without complications.
Comment From: dimitra-karadima
Ok @attack68 thank you!