promotes consistency, see #3021, #3016, #9065
Comment From: jbrockmendel
Can this be closed as Sufficiently Stale? If not, -1 on moving anything in to internals.
Comment From: jbrockmendel
@jreback closeable?
Comment From: jreback
no .update should be moved to internals l for sure it’s pretty much the only method outside
Comment From: TrigonaMinima
@jreback could you guide me here. If I understand this correctly, the required changes are in pandas/core/frame.py
and pandas/core/internals/manager.py
. Will there be any other files where the modification will be required? I guess test files too.
Comment From: jbrockmendel
The presence of filter_func in DataFrame.update means we have to operate column-wise instead of block-wise when it is present. We could also have a blockwise implementation as a Manager method, but i dont think its worth the duplication.
The Series.update signature doesn't match DataFrame.update. Would be nice to get those aligned.
Comment From: jbrockmendel
Closing as infeasible for reasons described above.