xref: #42744
We'll be making the pandas documentation have a dark mode soon. But some boxes in the docs home seem to have a white background, instead of a transparent one:
We should remove any custom style that is preventing the dark mode to work properly.
The changes can be tested against this branch to see if they work properly: #48285
Comment From: valanm22
@datapythonista May I work on this issue?
Comment From: datapythonista
@datapythonista May I work on this issue?
Sure, please do. Thanks @valanm22
Comment From: valanm22
Do I replace the old svg images or do I upload them as new svg images?
Comment From: datapythonista
Better replace the old images.
Comment From: valanm22
Ok got it.
Comment From: thekavikumar
I'll also try to fix it
Comment From: datapythonista
Looks like the problem are not the svg images, but the styles. I updated the description.
Comment From: thekavikumar
I'm not able to run python make.py HTML showing error module not found: No module named 'pandas._libs.interval any solution?
Comment From: datapythonista
In the project root run ./setup.py build_ext --inplace to compile pandas extensions, that should fix it. In the contributing documentation you have all the info.
Comment From: thekavikumar
That works! Now I will work on the styles and please do close this issue
Comment From: seanjedi
Is this issue still open? Seems to be resolved?
Comment From: datapythonista
The only thing I see that still doesn't show well in the dark mode is this section: https://pandas.pydata.org/docs/dev/getting_started/index.html#intro-to-pandas
We can close this issue when the background of that block is set to dark, and we check that things look good with it.
Comment From: anushkabishnoi
Hi I tried visiting the webpage you linked above, but since dark mode isn't released yet, it would be really helpful if you upload a screenshot of the portion to be modified. (willing to work on this issue :))
Comment From: datapythonista
The dark mode is released. If you don't have your browser in dark mode, you can get it with the icon in the right top of the docs.
Comment From: anushkabishnoi
oh okay, thanks
Can I work on this issue?
Comment From: anushkabishnoi
oh okay, thanks
Can I work on this issue?
This is my first time working with open source, it would be really helpful if you could guide me to files that need modification.
Thanks in advance :)
Comment From: datapythonista
Sure, thanks for the help. I think this PR should be similar to https://github.com/pandas-dev/pandas/pull/48572/files
You can build the documentation after creating an environment (see https://pandas.pydata.org/docs/dev/development/contributing_environment.html) running the make.py script inside doc/. The development documentation I point to has more detailed information.
Comment From: PKNaveen
is this issue closed or still open?
Comment From: datapythonista
is this issue closed or still open?
There is a PR open, it'll be merge shortly. But there is #51860, which is related and you can work on if you are looking for something to contribute.