Problem description
The manylinux1 wheels for cp36 pandas 0.24.1 don't have License files. See https://files.pythonhosted.org/packages/e6/de/a0d3defd8f338eaf53ef716e40ef6d6c277c35d50e09b586e170169cdf0d/pandas-0.24.1-cp36-cp36m-manylinux1_x86_64.whl for example.
Comment From: rahulporuri
Note that the wheels for pandas 0.23.4 + cp36 have license files missing on both macosx and manylinux1.
Comment From: TomAugspurger
Are they just missing for the 3.6 wheels?
On Tue, Feb 19, 2019 at 11:25 AM Poruri Sai Rahul notifications@github.com wrote:
Note that the wheels for pandas 0.23.4 + cp36 have license files missing on both macosx and manylinux1.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pandas-dev/pandas/issues/25374#issuecomment-465229284, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQHIp-PrFGBziiNk6b9pF89dTYMFaXnks5vPDOUgaJpZM4bDebl .
Comment From: rahulporuri
Are they just missing for the 3.6 wheels?
I did a full audit of 0.24.1 wheels and all of the manylinux1 (686, 64) (2.7, 3.5, 3.6, 3.7) wheels are missing the license file in the dist-info dir.
Comment From: TomAugspurger
Thanks. Interested in looking into why it's not being included?
On Tue, Feb 19, 2019 at 3:37 PM Poruri Sai Rahul notifications@github.com wrote:
Are they just missing for the 3.6 wheels?
I did a full audit of 0.24.1 wheels and all of the manylinux1 (686, 64) (2.7, 3.5, 3.6, 3.7) wheels are missing the license file in the dist-info dir.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pandas-dev/pandas/issues/25374#issuecomment-465320498, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQHIk4Q64NagQmJC0bdFbKPqV8aT7iEks5vPG59gaJpZM4bDebl .
Comment From: rahulporuri
It looks like https://github.com/pandas-dev/pandas-release is the infrastructure used to create wheels for manylinux. If it is, I can try looking at why the files are missing over the week.
Comment From: TomAugspurger
Correct. For manylinux, we use multibuild.
I would start by looking here, to ensure that a simple python setup.py
bdist_wheel on master produces a wheel with the license file.
On Tue, Feb 19, 2019 at 4:04 PM Poruri Sai Rahul notifications@github.com wrote:
It looks like https://github.com/pandas-dev/pandas-release is the infrastructure used to create wheels for manylinux. If it is, I can try looking at why the files are missing over the week.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pandas-dev/pandas/issues/25374#issuecomment-465329585, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQHIv4CBo2QTZpWpw2T5Mlr9LnSLiaYks5vPHTegaJpZM4bDebl .
Comment From: rahulporuri
That's weird. python setup.py bdist_wheel doesn't produce a wheel with the license file either. But the License file is listed in the manifest so i'm not sure what's going on. Investigating.
...
adding 'pandas/util/_validators.py'
adding 'pandas/util/testing.py'
adding 'pandas-0.25.0.dev0+138.g2909b830f.dist-info/DESCRIPTION.rst'
adding 'pandas-0.25.0.dev0+138.g2909b830f.dist-info/metadata.json'
adding 'pandas-0.25.0.dev0+138.g2909b830f.dist-info/top_level.txt'
adding 'pandas-0.25.0.dev0+138.g2909b830f.dist-info/WHEEL'
adding 'pandas-0.25.0.dev0+138.g2909b830f.dist-info/METADATA'
adding 'pandas-0.25.0.dev0+138.g2909b830f.dist-info/RECORD'
Comment From: mroeschke
I don't think this is an issue with our CI BuildWheel setup for newer versions of pandas so closing. Can reopen if this issue shows up again