@philwebb this one is a bit interesting as to where the "home" for the auto-configuration should go for "DiskSpaceMetrics". It is in the Micrometer JVM package but feels a bit more like "System" metrics.
2 reasons I landed it in the JvmMetricsAutoConfiguration:
- I rooted it to user.dir which is the current working directory the JVM was launched from
- the metrics implementation uses methods on File that are from the viewpoint of the VM. For example, from File.getUsableSpace :
> Returns the number of bytes available to this virtual machine on the partition named by this abstract pathname
Fixes gh-25996
Comment From: snicoll
Thanks again @bono007.
Comment From: onobc
Thanks again @bono007.
My pleasure @snicoll