@bclozel I put together a WIP and wanted to get a nod from you (or not) on my current direction before investing in adding tests.
Fixes gh-26037
Comment From: aoudiamoncef
Hi @bono007,
I'm interested on this PR, if you wanna a help, don't hesitate.
Comment From: onobc
Hi @aoudiamoncef - I almost forgot about this proposal, thanks for the reminder. I was waiting for nod from @bclozel before I continued w/ adding tests. I will go ahead and add them in the next 1-2 days.
Comment From: bclozel
Thanks @bono007 , please go ahead with tests and what you had in mind. I'll do a proper review of that one - I need to review what we have in Framework and probably ask around to make sure we're on the right track!
Comment From: onobc
I believe this one is ready for re-review @bclozel . Thx
Comment From: bclozel
Thanks @bono007 - this is now merged.
I've simplified a bit your contribution: the DefaultPartHttpMessageReader itself doesn't validate its properties against conflicting values, so let's not do that on our side. Also, not mapping properties might confuse developers more than help them. The properties documentation looks good enough for that.
Closed with 19318bf5618020c3e
Comment From: onobc
Thx @bclozel . Yeh, I went back/forth on that. What drove my direction was mostly the comment in the issue around:
Note that we need to carefully consider the configuration keys, as several of them don't apply if the "streaming" mode is selected.
I figured if we put the logic in the customizer it would insulate us from any changes in the DPHMR around setting/not setting.
But I agree, this simplifies things.