SpringBoot Add support for multiple paths in DiskSpaceHealthIndicator

Fixed gh-18359

Assumption

I know there was a previous proposal that was closed due to concerns around breaking compatibility of the actuator output when configuring each path's threshold. This code proposal assumes that breaking the output is ok since this is going into 2.6.

Etiquette

I am not sure what the etiquette is in the situation where there is a dated closed proposal. I am starting to work on the counterpart of this for the DiskSpaceMetrics and figured I would put this together. If instead, we should resurrect the elder proposal I am totally fine w/ that as well. This newer implementation does support configuring the threshold per each path. I am not trying to be rude or step on toes.

Usage

The config props now look like the following:

management.health.diskspace.paths:

  - path: /some/dir/path1
    threshold: 10GB

  - path: /some/other/path2

  - path: /some/extra/path3
    threshold: 100MB

I am not super excited about the "paths.path"
With low effort we could also keep the existing "management.health.diskspace.path" for the singular case. Thoughts?

Comment From: wilkinsona

This code proposal assumes that breaking the output is ok since this is going into 2.6

The breaking changes we rejected previously, not because of their timing, but because there hadn't been much demand for them. As such, it was hard to justify the cost of the breaking change. The situation has changed a little bit since then as the request for disk space metrics is related to this and I think it makes sense for the two to be in sync in terms of their configuration. I'm not sure if that warrants making a breaking change in 2.6, if we should defer everything till 3.0, or if we should ship disk space metrics with configuration that's out of sync with disk space health. Flagging for team meeting so that we can discuss our options once again.

Comment From: wilkinsona

Thanks for the proposal here, @bono007. In light of https://github.com/spring-projects/spring-boot/issues/27306#issuecomment-903907394, we no longer want to add support for configuring the disk space health indicator with multiple paths.