It is important to not only know that a service is unhealthy, but also why it is (which health check, description). Unfortunately
some external monitoring systems do not provide the output/body of the HTTP request or do not create a history of that. A simple log message solves the issue completely in these cases.
For this reason I implemented a log statement in case the health check is not UP
. To not change the default behavior and annoy people I choosed the DEBUG
level.
I think that can be a useful feature for some people and does not harm anyone else.
btw: Its a bit unclear for me how you manage your branches. If this is merged into master, how will it be integrated best into 2.2.x
and 2.3.x
?
Comment From: philwebb
See #22632
Comment From: mbhave
@jackhammer2k We have decided to use the approach suggested by @snicoll here by exposing an accessor for the exception
on the builder
. Thanks anyway and sorry for the wasted effort.