~~I've created a class to provide exposing of SettingsCreator#createFrom
. As it is now public, name SettingsCreator
is not very helpful, and that's why I created another class for exposing purpose (backward compatibility is kept)~~
Link: https://github.com/spring-projects/spring-boot/issues/26657
Comment From: OrangeDog
Adding another class seems like a bad idea. What about my suggestion on the original issue?
Comment From: radoslawdabrowski
So, I am taking an advice and I implemented that in a way you suggested
Comment From: snicoll
I've noticed that SqlDataSourceScriptDatabaseInitializer
has a public accessor via getSettings
so I am wondering what we should do here after all.
Paging @wilkinsona
Comment From: radoslawdabrowski
Yes, I also noticed that (also there is SqlR2dbcScriptDatabaseInitializer#getSettings
) and was wondering if this change is needed but in case mentioned by @OrangeDog it is not very useful I guess.
Comment From: wilkinsona
There are also the overloaded constructors on the …DatabaseInitializer
classes that were introduced in https://github.com/spring-projects/spring-boot/issues/27206. I don't think we need to make any changes here now. Apologies for the wasted effort here, @radoslawdabrowski.