See Add .gitattributes.
Comment From: pivotal-cla
@Goooler Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@Goooler Thank you for signing the Contributor License Agreement!
Comment From: wilkinsona
I think we need to tread carefully here. CI currently uses core.autocrlf=true:
https://github.com/spring-projects/spring-boot/blob/8966b1308b17f1a8c4e50b25508f4b17e10fa20f/ci/pipeline.yml#L127-L129
I'm not sure how this change will interact with that configuration.
Comment From: Goooler
I think we need to tread carefully here. CI currently uses
core.autocrlf=true:https://github.com/spring-projects/spring-boot/blob/8966b1308b17f1a8c4e50b25508f4b17e10fa20f/ci/pipeline.yml#L127-L129
I'm not sure how this change will interact with that configuration.
.gitattributes should just effect files when commiting.
Comment From: philwebb
https://git-scm.com/docs/gitattributes#_checking_out_and_checking_in seems to suggest they also change checked out files.
Comment From: Goooler
If we should run CI for test once ?
Comment From: snicoll
Unfortunately we need to revert this change for now, see #28476 for follow-up